Browse Source

Fix CI runs: Do not follow symlinks when tarring the build artifact

8.x-4.x
Volker Killesreiter GitHub 2 months ago
parent
commit
571994fe2d
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 6 additions and 4 deletions
  1. +2
    -1
      .github/workflows/test.yml
  2. +1
    -0
      .gitignore
  3. +2
    -2
      tests/src/FunctionalJavascript/ArticleCreationTest.php
  4. +1
    -1
      tests/src/FunctionalJavascript/Integration/LiveblogTest.php

+ 2
- 1
.github/workflows/test.yml View File

@@ -21,6 +21,7 @@ env:
DRUPAL_TESTING_INSTALLATION_FORM_VALUES: "thunder_module_configure_form.install_modules_thunder_demo=NULL"
DRUPAL_TESTING_TEST_GROUP: Thunder
THUNDER_ADMIN_BRANCH: 8.x-3.x
DRUPAL_TESTING_COMPOSER_PROJECT_VERSION: 3.0.8

jobs:

@@ -75,7 +76,7 @@ jobs:
run: test-drupal-project install

- name: Zip build
run: cd /tmp/test; tar cfhz build.tgz thunder; mv build.tgz ${GITHUB_WORKSPACE}
run: cd /tmp/test; tar cfz build.tgz thunder; mv build.tgz ${GITHUB_WORKSPACE}

- name: Upload build
uses: actions/[email protected]


+ 1
- 0
.gitignore View File

@@ -7,3 +7,4 @@
composer.lock
package-lock.json
phpunit.xml
.phpunit.result.cache

+ 2
- 2
tests/src/FunctionalJavascript/ArticleCreationTest.php View File

@@ -96,8 +96,8 @@ class ArticleCreationTest extends ThunderJavascriptTestBase {

// Check that one Twitter widget is on page.
$this->getSession()
->wait(5000, "jQuery('twitter-widget').filter(function(){return (this.id.indexOf('twitter-widget-0') !== -1);}).length === 1");
$numOfElements = $this->getSession()->evaluateScript("jQuery('twitter-widget').filter(function(){return (this.id.indexOf('twitter-widget-0') !== -1);}).length");
->wait(5000, "jQuery('iframe').filter(function(){return (this.id.indexOf('twitter-widget-0') !== -1);}).length === 1");
$numOfElements = $this->getSession()->evaluateScript("jQuery('iframe').filter(function(){return (this.id.indexOf('twitter-widget-0') !== -1);}).length");
$this->assertEquals(1, $numOfElements, "Number of twitter on page should be one.");

// Check Link Paragraph.


+ 1
- 1
tests/src/FunctionalJavascript/Integration/LiveblogTest.php View File

@@ -140,7 +140,7 @@ class LiveblogTest extends ThunderJavascriptTestBase {
$this->createScreenshot($this->getScreenshotFolder() . '/ModuleIntegrationTest_Liveblog_TwitterPost_' . date('Ymd_His') . '.png');

$this->waitUntilVisible('article[data-postid="3"]', 10000);
$this->waitUntilVisible('[data-tweet-id="778001033142284288"].twitter-tweet-rendered', 10000);
$this->waitUntilVisible('.twitter-tweet-rendered [data-tweet-id="778001033142284288"]', 10000);

// We can't check inside Twitter widget is it loaded or not, that's why
// plain wait is used.


Loading…
Cancel
Save